Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testing for Weddings #98

Merged
merged 10 commits into from
Oct 17, 2024

Conversation

HanB1n
Copy link

@HanB1n HanB1n commented Oct 16, 2024

Add test for Wedding functions.

Add test for Wedding functions.
Fix conflicts in Messages.java
Fix conflicts in UntagCommand.java
Fix conflicts in AddressBookParser.java
Fix conflicts in AddressBook.java
Fix check style issues in Wedding classes.
Fix check style issues in Wedding test classes.
@HanB1n HanB1n self-assigned this Oct 16, 2024
@HanB1n HanB1n added this to the v1.3 milestone Oct 16, 2024
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ Complexity Δ
src/main/java/seedu/address/logic/Messages.java 90.90% <ø> (+4.54%) 5.00 <0.00> (+1.00)
...address/logic/commands/UnassignWeddingCommand.java 86.11% <ø> (+72.22%) 10.00 <0.00> (+8.00)
.../seedu/address/logic/parser/EditCommandParser.java 88.23% <ø> (+8.82%) 13.00 <0.00> (+1.00)
src/main/java/seedu/address/model/AddressBook.java 85.52% <100.00%> (+2.63%) 29.00 <1.00> (+1.00)

... and 10 files with indirect coverage changes

@HanB1n HanB1n linked an issue Oct 16, 2024 that may be closed by this pull request
Add tests for UnassignWeddingCommand.
Add tests for AssignWeddingCommand.
Add tests for DeleteWeddingCommand.
Add tests for CreateWeddingCommand.
Copy link

@dasha3412 dasha3412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

# Conflicts:
#	src/main/java/seedu/address/logic/Messages.java
#	src/main/java/seedu/address/logic/commands/AssignWeddingCommand.java
#	src/main/java/seedu/address/logic/commands/CreateWeddingCommand.java
#	src/main/java/seedu/address/logic/commands/DeleteWeddingCommand.java
#	src/main/java/seedu/address/logic/commands/UnassignWeddingCommand.java
#	src/main/java/seedu/address/model/AddressBook.java
#	src/main/java/seedu/address/model/Model.java
#	src/main/java/seedu/address/model/ReadOnlyAddressBook.java
#	src/main/java/seedu/address/model/person/Person.java
#	src/main/java/seedu/address/model/wedding/UniqueWeddingList.java
#	src/main/java/seedu/address/model/wedding/Wedding.java
#	src/main/java/seedu/address/model/wedding/WeddingName.java
#	src/test/java/seedu/address/logic/parser/CreateWeddingCommandParserTest.java
#	src/test/java/seedu/address/logic/parser/DeleteWeddingCommandParserTest.java
#	src/test/java/seedu/address/model/AddressBookTest.java
#	src/test/java/seedu/address/testutil/TypicalPersons.java
Remove setTag from UniqueWeddingList.java.
Bug fix for compatibility with Weddings in
EditPersonDescriptorBuilder.java.
Copy link

@DanzaSeah DanzaSeah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM

@dasha3412 dasha3412 merged commit bc42d4f into AY2425S1-CS2103T-F15-4:master Oct 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add testing for weddings
3 participants