forked from nus-cs2103-AY2425S1/tp
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add testing for Weddings #98
Merged
dasha3412
merged 10 commits into
AY2425S1-CS2103T-F15-4:master
from
HanB1n:branch-wedding
Oct 17, 2024
Merged
Add testing for Weddings #98
dasha3412
merged 10 commits into
AY2425S1-CS2103T-F15-4:master
from
HanB1n:branch-wedding
Oct 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test for Wedding functions.
Fix conflicts in Messages.java Fix conflicts in UntagCommand.java Fix conflicts in AddressBookParser.java Fix conflicts in AddressBook.java
Fix check style issues in Wedding classes. Fix check style issues in Wedding test classes.
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
Closed
Add tests for UnassignWeddingCommand.
Add tests for AssignWeddingCommand.
Add tests for DeleteWeddingCommand.
Add tests for CreateWeddingCommand.
dasha3412
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
# Conflicts: # src/main/java/seedu/address/logic/Messages.java # src/main/java/seedu/address/logic/commands/AssignWeddingCommand.java # src/main/java/seedu/address/logic/commands/CreateWeddingCommand.java # src/main/java/seedu/address/logic/commands/DeleteWeddingCommand.java # src/main/java/seedu/address/logic/commands/UnassignWeddingCommand.java # src/main/java/seedu/address/model/AddressBook.java # src/main/java/seedu/address/model/Model.java # src/main/java/seedu/address/model/ReadOnlyAddressBook.java # src/main/java/seedu/address/model/person/Person.java # src/main/java/seedu/address/model/wedding/UniqueWeddingList.java # src/main/java/seedu/address/model/wedding/Wedding.java # src/main/java/seedu/address/model/wedding/WeddingName.java # src/test/java/seedu/address/logic/parser/CreateWeddingCommandParserTest.java # src/test/java/seedu/address/logic/parser/DeleteWeddingCommandParserTest.java # src/test/java/seedu/address/model/AddressBookTest.java # src/test/java/seedu/address/testutil/TypicalPersons.java
Remove setTag from UniqueWeddingList.java.
Bug fix for compatibility with Weddings in EditPersonDescriptorBuilder.java.
DanzaSeah
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test for Wedding functions.